Add additional fields to the Request objects #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess hostname, protocol, and secure options of the request. On the client side, it looks in the window.location variable for the info.
doug-wade
approved these changes
Nov 17, 2016
|
Nice! This is a really useful improvement. Thanks @drewpc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request objects available through
this.getRequest()in middleware and elsewhere in the codebase provide access to the path and query portions of a URI (scheme:[//[user:password@]host[:port]][/]path[?query][#fragment]). This PR incorporates changes to the client and server side request wrappers to return scheme, host, and "secure" (matches the ExpressJS request object) values. This does not address port, user, password, or fragment at this time. The client implementation useswindow.locationif available and falls back to returning null. The server implementation uses the ExpressJS request object.